search

SecUpwN / Spotify-AdKiller

Your Party with Spotify - without ads!
https://github.com/SecUpwN/Spotify-AdKiller
GNU General Public License v3.0
836 stars 83 forks source link

Automatically detect spotify-make #49

Open SecUpwN opened 8 years ago

SecUpwN commented 8 years ago

Since I am one of the enthusiasts using spotify-make to install and run the latest version of Spotify, I would like to see Spotify (AdKiller).desktop automatically detect the installation of spotify-make, which moves its own launcher into /bin/my-spotify. In order to launch my-spotify, I always have to manually modify Spotify (AdKiller).desktop. Long ago, I tried to make our spotify-wrapper.sh to generically detect this with #2, but that did not work at all. We currently state the following in our README:

You can create a symbolic link, if necessary (e.g. linking my-spotify to spotify if you are using the user installation of spotify-make).

Spotify (AdKiller).desktop (or maybe spotify-wrapper.sh) should check how Spotify has been installed and then launch the correct binary file. Would you please have a look at this, @Feltzer?

Maybe @leamas can help us to improve our script here with a pull request or two? Would be lovely!

Feltzer commented 8 years ago

tbh, I don't think that this should be handled by our scripts. It would be too much of a headache to maintain a list of possible binary names for spotify.

spotify-make also seems to offer a system-wide installation now which follows the regular binary naming convention (my understanding is that the local installation is renamed to my-spotify to allow for a parallel install of both a local version and system-wide version of Spotify).

I think we should just update the README to direct users to follow the installation instructions for the system-wide install.

SecUpwN commented 8 years ago

tbh, I don't think that this should be handled by our scripts. It would be too much of a headache to maintain a list of possible binary names for spotify.

What do you mean by maintaining a list of possible binary names for Spotify?

spotify-make also seems to offer a system-wide installation now which follows the regular binary naming convention

Now? Too bad that @leamas does not seem to care to properly maintain his repo, last update was on June 29, 2015. Pull requests and superold Issues (stuff from 2013) are still waiting in his queue.

I think we should just update the README to direct users to follow the installation instructions for the system-wide install.

@Feltzer, to which install instructions should I link to exactly?

Feltzer commented 8 years ago

What do you mean by maintaining a list of possible binary names for Spotify?

Right now we would only have to account for my-spotify, but I am sure other projects use different naming conventions, which we would have to consider adding over time. With things like this it's usually up to upstream (the projects we depend on) to maintain compatibility with other projects.

Fortunately spotify-make does offer an installation routine that's compatible with our script (and every other project depending on spotify) right out of the box: It's the second list of installation instructions in the usage section, the system-wide installation: https://github.com/leamas/spotify-make#usage.

Now? Too bad that @leamas does not seem to care to properly maintain his repo, last update was on June 29, 2015. Pull requests and superold Issues (stuff from 2013) are still waiting in his queue.

That's unfortunate to hear. It has been a while since I looked at that repo, so I thought this was new.

In any case, the important thing is that installing spotify-make system-wide takes care of the naming issue.

SecUpwN commented 8 years ago

Fortunately spotify-make does offer an installation routine that's compatible with our script (and every other project depending on spotify) right out of the box: It's the second list of installation instructions in the usage section, the system-wide installation: https://github.com/leamas/spotify-make#usage.

Thanks. Do you think extending our current note under Troubleshooting is good eneough to make people aware of this, or shall I add a separate note in Installation? Currently we tell them this:

You can create a symbolic link, if necessary (e.g. linkingmy-spotifytospotifyif you are using the user installation of [spotify-make](https://github.com/leamas/spotify-make)).

In any case, the important thing is that installing spotify-make system-wide takes care of the naming issue.

Well, I cannot test that until https://github.com/leamas/spotify-make/issues/40 has been solved.

Feltzer commented 8 years ago

Yeah, I think we should just update the troubleshooting section.

SecUpwN commented 8 years ago

Yeah, I think we should just update the troubleshooting section.

Will do so soon and update our CHANGELOG.md as well. Stay tuned. Thanks for helping to improve our script, @Feltzer, even when you are short on time. Hope you also starred and use our AIMSICD. :smile_cat: