search

SecUpwN / Spotify-AdKiller

Your Party with Spotify - without ads!
https://github.com/SecUpwN/Spotify-AdKiller
GNU General Public License v3.0
847 stars 86 forks source link

Stopped working with new version of Spotify #50

Closed kodzak closed 8 years ago

kodzak commented 8 years ago

Adds aren't blocked. Changing name from "Spotify Free - Linux Preview" on "Spotify" in config file(spotify-adkiller.sh) nothing change. Adds still are played.

OlegSmelov commented 8 years ago

Just tested Spotify 1.0.23.93 on Ubuntu 15.04 and it worked.

@kodzak Can you provide more information? Distro, exact Spotify version, logs, ...

kodzak commented 8 years ago

I use elementary Os Freya it is based on Ubuntu 14.04. Spotify version 1.0.23.93.gd6cfae15. Script mute adds only if i pause and play again. Not mute adds automatically. I download again this script and still this happened.

billpcs commented 8 years ago

Can confirm the exact same behaviour on the exact same system.

System: elementary OS Freya x86_64 Spotify version 1.0.23.93.gd6cfae15

Here is some explanation of a sample run

info

raphatbho commented 8 years ago

Ubuntu 14.04 and I can confirm the same problem.

Pafrak commented 8 years ago

Here is what happens to me:

$ spotify-wrapper.sh 
## Waiting for Spotify ##
## Waiting for Spotify ##
## Waiting for Spotify ##
## Waiting for Spotify ##
## Waiting for Spotify ##
## Waiting for Spotify ##
## Waiting for Spotify ##
## Waiting for Spotify ##
## Waiting for Spotify ##
## Waiting for Spotify ##
Error: Spotify not found.

Spotify opens automatically after spotify-wrapper.sh is called, but on the shell it seems it does not recognize that the program is executing...

Ubuntu 14.04 Spotify version 1.0.23.93.gd6cfae15 Just checked out spotify-wrapper to be sure to have the latest version as well

Few days ago it was working.....

--------UPDATE-----------

I installed it from scratch, and it is working now!

rjd22 commented 8 years ago

I have the same problem the problem I'm having is that spotify creates multiple audio sinks and plays in a different audio sink than the blocker blocks.

So ads keep playing while the blocker blocks the wrong audio sink. I changed the blocker to block both audio sinks and now it's working but nothing keeps spotify to open 3 sinks to work around this problem.

SecUpwN commented 8 years ago

Sorry folks that you're having so many troubly with it currently. @Feltzer, can you digg into this, please?

mad73923 commented 8 years ago

Seems like the new version doesn't publish the current title to the system media control. Every new title I get a desktop notification with the title, but the album cover and other info isn't shown in the systems media box anymore. Any fix for this? Linux Mint 17.3 Spotify 1.0.24.104.g92a22684

UPDATE: somehow it's working now (ads muted, but still no album cover). don't ask me what i did. reboot!? Didn't change anything with the adblocker or spotify.

Micr0Bit commented 8 years ago

i can confirm this bug ... on Debian GNU/Linux 8.3 (jessie)

"Script mute adds only if i pause and play again"

rjd22 commented 8 years ago

I can confirm what @Micr0Bit says. It stopped detecting ads correctly. Only after I pause and play again it is able to see that it's an ad running.