search

SecUpwN / Spotify-AdKiller

Your Party with Spotify - without ads!
https://github.com/SecUpwN/Spotify-AdKiller
GNU General Public License v3.0
836 stars 83 forks source link

Fix default config #53

Closed saladpanda closed 8 years ago

saladpanda commented 8 years ago

See https://github.com/SecUpwN/Spotify-AdKiller/blob/master/spotify-adkiller.sh#L167

SecUpwN commented 8 years ago

Thanks for the fix, @datamaan! Would you please clarify why this is currently wrong?

saladpanda commented 8 years ago

Oh, sorry for being so brief. :-)

The default config currently says that the default mode is "continuous", but the code actually has "simple" as the default. So one of the two should be fixed. I thought it would make more sense to correct the comment in the configs.

SecUpwN commented 8 years ago

Thanks for clarifying, @datamaan. Using continuous mode by default makes much more sense though since it prevents the awkward pause in between. Are you able to update your pull request to use that?

saladpanda commented 8 years ago

I already deleted my fork. But I made a new one: #54