SecUpwN / Spotify-AdKiller

Your Party with Spotify - without ads!
https://github.com/SecUpwN/Spotify-AdKiller
GNU General Public License v3.0
836 stars 83 forks source link

VLC no longer supports "--volume" option #56

Open saladpanda opened 8 years ago

saladpanda commented 8 years ago

When manually issuing the cvlc command in I get Warning: option --volume no longer exists.

I can't find out when and why they removed it, but as it stands the option is simply ignored which leads to vlc using the volume it had on last close.

I think it should be possible to adjust the volume via pacmd in the same way that you contol the spotify sink.

SecUpwN commented 8 years ago

@videolan, we'd appreciate it if you could give us a clue on this. Thank you!

saladpanda commented 8 years ago

Just asked on the videolan IRC. Answer: "[...] volume is set by pulseaudio, not by VLC"

So it seems to be pacmd for this one.

SecUpwN commented 8 years ago

So it seems to be pacmd for this one.

Please rename this Issue accordingly and if possible @mention a person able to digg into this. Thanks.

saladpanda commented 8 years ago

The issue name is correct. I don't see a need to change it.

Why should I mention anybody? I'm no member of this project. This is a bugreport. Everyone is free to look into it and send you pull requests etc.

Dmole commented 6 years ago

It is now;

> cvlc --full-help | grep -A 2 \\-\\-gain | tail -n 3
VLC media player 2.2.2 Weatherwax (revision 2.2.2-0-g6259d80)
      --gain <float [0.000000 .. 8.000000]> 
                                 Audio gain
          This linear gain will be applied to outputted audio.

unlike the following that don't influence the VLC pre-amp;

> cvlc --full-help | grep \\-vol
VLC media player 2.2.2 Weatherwax (revision 2.2.2-0-g6259d80)
      --v4l2-audio-volume <integer [-2147483648 .. 2147483647]> 
      --dvb-voltage <integer [0 .. 18]> 
      --dvb-high-voltage, --no-dvb-high-voltage 
      --sout-raop-volume <integer [0 .. 255]> 
      --qt-max-volume <integer [60 .. 300]> 
      --volume-step <float [1.000000 .. 256.000000]> 
      --volume-save, --no-volume-save 
      --global-key-vol-up <string> 
      --key-vol-up <string>      Volume up
      --global-key-vol-down <string> 
      --key-vol-down <string>    Volume down
      --global-key-vol-mute <string> 
      --key-vol-mute <string>    Mute