search

Second-Hand-Friends / kleinanzeigen-bot

A dilligent command line tool to publish ads on kleinanzeigen.de
GNU Affero General Public License v3.0
202 stars 44 forks source link

Correctly selects shipping even with condition present #202

Closed DreckSoft closed 11 months ago

DreckSoft commented 1 year ago

Fixes #195 and likely #196 I don't think the patch will work permanently. Maybe someone finds a better solution that just adjusting the class names all the time.

sebthom commented 1 year ago

Thanks for the PR. I won't have time for the next two weeks to review/incorporate this. Before this can be merged the build failures must be fixed. They are probably not related to your changes but probably to the fact that the action runner images got upgraded by Github.

DreckSoft commented 1 year ago

The PR is strage cause there are way too many changes mentioned and it's only a one-line change. However it should not break the build process.

sebthom commented 1 year ago

maybe you need to rebase your branch. if this doesn't work throw the fork away, fork again and create a fresh PR.

nalt commented 1 year ago

This shipping feature seems to be changing a lot right now. I doubt .jsx-2623555103 is a stable selector. Maybe .SelectionButton?

Also, note that the website first shows a dropdown for shipping options, which is then removed and replaced by the radio buttons. However, this is not the case in all account types – in some accounts, the dropdown list stays.