search

Second-Hand-Friends / kleinanzeigen-bot

A dilligent command line tool to publish ads on kleinanzeigen.de
GNU Affero General Public License v3.0
197 stars 43 forks source link

Update Categories #274

Open cooukiez opened 5 months ago

cooukiez commented 5 months ago

Description of changes: I removed old category.yaml file and replace with the complete category list, I scraped from kleinanzeigen.de. These should be all categories as of March 2024. I created a category tree therefore all leaf categories are included in the yaml-file (with name and path).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

TylonHH commented 4 months ago

Is this request related with this? https://github.com/Second-Hand-Friends/kleinanzeigen-bot/issues/281#issuecomment-2068007851

cooukiez commented 4 months ago

Yes, as I said, I directly scraped every category from kleinanzeigen.de

https://github.com/Second-Hand-Friends/kleinanzeigen-bot/pull/274/commits/bdbf1ced181bae63d83a0644ab3506288643d0fd#r1573870001

cooukiez commented 4 months ago

Someone would need to replace special german characters, then builds wont fail I think

provinzio commented 3 months ago

@cooukiez I realized that the encoding of the new categories.yaml file wasn't utf-8. (perhaps used python open(...) without encoding="utf-8" as parameter?) I fixed the encoding and opened another PR with a fixed pipeline.

Have you used a script to scrape the new categories? Might be nice to save it somewhere near in case we need it again. Good work. :)