search

Second-Hand-Friends / kleinanzeigen-bot

A dilligent command line tool to publish ads on kleinanzeigen.de
GNU Affero General Public License v3.0
197 stars 43 forks source link

Draft: Minor improvement and bugfixes #303

Closed provinzio closed 3 months ago

provinzio commented 3 months ago

Issue #, if available: #276, #300, #301, #292

Minor improvement and bugfixes in multiple commits grouped as one PR. Feel free to the cherry pick single commits as you like or give me a quick hint how I should prepare the PR for you.

Detailed explanations can be found in the commit messages.

Download

  1. FIX extract sell directly from ad page (6bc07de682c491bbe9839206cbbc2cedd9577128)

Publish

  1. FIX setting price type correctly (72bb550a359ee7f94a57e1a05abade50e20195ad fixes #276, fixes #300)
  2. UPDATE wait for user interaction to solve captcha on publishing ad (66bbaa81b9b2c9e4bfdff1592248f754261c57f9 fixes #301)
  3. FIX selection of shipping options Klein (0054f5a39cfd852fb0f67ffe117b2cbac1544bb1, fixes #292)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

provinzio commented 3 months ago

Hey, I realized that FIX selection of shipping options Klein does not solve the issue correctly. I thought that the shipping option Klein is always preselected. But as it seems, Kleinanzeigen sets a default shipping option in the UI. Therefore our code has to check which default shipping options was selected by the UI.

I have to come back onto this. I mark this PR as draft. Sorry for that.

Edit: also saw a overseen pylint warning. I'll fix that too.

Edit2: I realized that it was a bad idea, to create a PR with everything put together in in. I'll create single PR for every thing.