search

SecondHalfGames / yakui

yakui is a declarative Rust UI library for games
Apache License 2.0
230 stars 21 forks source link

panic when missing font #172

Closed sanbox-irl closed 3 months ago

sanbox-irl commented 3 months ago

This PR simply adds a panic when a font is missing. This obviously would be a breaking change for some users who might rely on the current behavior.

I'm not sure that panic is the correct decision here, but the API really doesn't allow for anything besides that, or the current behavior here. I am making this PR because I believe that panicking is superior given only those two options.

I am open to this PR being rejected without too much complaining -- I understand there might be a difference in direction here

sanbox-irl commented 3 months ago

bumpin!

LPGhatguy commented 3 months ago

Timely bump given the recent conversation about panicking!

I'm down for this change.