Implement cosmic_text as the text renderer and editor

SecondHalfGames / yakui

yakui is a declarative Rust UI library for games

Apache License 2.0

237 stars 21 forks source link

Implement cosmic_text as the text renderer and editor #179

Open msparkles opened 4 months ago

msparkles commented 4 months ago

Closes #95

msparkles commented 4 months ago

~~Weird text bug on yakui demo~~ Fixed!

msparkles commented 4 months ago

Unsure of why the tests are failing!

msparkles commented 4 months ago

Need input on the tests

Otherwise should be ready for review!

msparkles commented 4 months ago

Hm! Either I'm doing something wrong here, or whatever #125 aims to fix is hitting me hard here.

It seems that if I switch to another page in my game, textboxes will happily reuse the contents of the old one selected.

LPGhatguy commented 4 months ago

Even after #125 or a similar fix, you'll still run into that until we fix widget keys. More details in Discord!

Ideally, widgets are able to react to props changing so that it isn't a major issue to reuse widget state but sometimes that isn't possible.

msparkles commented 4 months ago

we've made a branch that contains code to solve the issue. but it depends on this pr because we were too lazy to find a reprod on main that actually does have the issue, lol!

msparkles commented 4 months ago

AAAaahhhhh. hi-dpi actually works now. This has become like 40 commits, god damn it

msparkles commented 2 months ago

oops squashed them wrongly i think

msparkles commented 2 months ago

apparently the text fixes broke the height of texts on certain fonts, so the actual thing we should've done was to change the tests :100: