Open cybersoulK opened 1 month ago
Interesting! This should be an easy fix and probably impacts our game too.
@LPGhatguy we're noticing in #179 that the coloured texts are already premul'd (at least as far as we can tell)
We also found a really bad performance issue in the alpha premultiplication.
We're committing a fix for those because it heavily affects coloured texts, it takes like 5s to write 3 coloured text characters on release right now, Oops!
P.S. We ran a profiler on yakui example to see that premul'd alpha really is taking too long. It's all on .round()
@msparkles Those changes seem useful even outside of cosmic text. If the conversion that removes round is the same, I'd take that in a separate PR.
I wonder where the best place to handle the premultiplication in the pipeline is.
Should we cherry-pick them into a separate branch?
https://github.com/SecondHalfGames/yakui/commit/f893ad1ead7bad401c0b0d62180f95fd114d6efa
The first image is before the commit, second is after the commit. The elements are colored_box and colored_box_container