SecondHalfGames / yakui

yakui is a declarative Rust UI library for games
Apache License 2.0
237 stars 21 forks source link

Add a widget for drawing outlines #191

Closed johann2 closed 1 month ago

johann2 commented 1 month ago

Needed one myself and it seems like it could be useful for others as well. I guess the same could be achieved with the NineSlice widget, but for simple outlines, this is much more ergonomic and doesn't need any setup.

Also added an example that showcases all the functionality this widget has.

msparkles commented 1 month ago

@johann2 BTW, a tip: when making PRs, cherry-pick the commits you want in the PR into a separate branch, and then make a PR from that

johann2 commented 1 month ago

@johann2 BTW, a tip: when making PRs, cherry-pick the commits you want in the PR into a separate branch, and then make a PR from that

I'm aware of this, but unfortunately forgot this step. GitHub doesn't allow changing the source branch of PRs, so should I just close this and create another one?

msparkles commented 1 month ago

so should I just close this and create another one?

Yeah, that's the best course of action here really.