search

SecondThundeR / shikithon

Yet another Python wrapper for Shikimori API
https://pypi.org/project/shikithon/
MIT License
8 stars 0 forks source link

Add pagination support in clubs resource #18

Closed SecondThundeR closed 1 year ago

SecondThundeR commented 1 year ago

Some methods have a page parameter (e.g. /api/clubs/xxx/animes, /api/clubs/xxx/mangas etc.), but they don't seem to work yet (no matter how I try to call them as a query (?page=xxx) or in body), API returns only the first 20 results and that's it. When this is fixed, I'll add support right away. In the meantime, this issue will stick around as a reminder for the future

The source file of the club's API controller: https://github.com/shikimori/shikimori/blob/master/app/controllers/api/v1/clubs_controller.rb

SecondThundeR commented 1 year ago

Yay https://github.com/shikimori/shikimori/commit/e8c12520544ef58716ff7765bd16ba00b6f0dbf3

SecondThundeR commented 1 year ago

Closed in a25e15