search

SecrecySupportTeam / secrecy

http://forum.xda-developers.com/showthread.php?t=2704486
Apache License 2.0
78 stars 27 forks source link

Minimum SDK version #115

Closed StelianMorariu closed 9 years ago

StelianMorariu commented 9 years ago

Could we consider increasing the minimum SDK version to 14/15 ?

distribution

L-Henke commented 9 years ago

What would be the advantage for us?

StelianMorariu commented 9 years ago

First thing is we could drop the PreferenceFragment library (if I'm not mistaken PreferneceFragment was added in api 11).

L-Henke commented 9 years ago

Sounds reasonable. But wouldn't it be enough then to increase it to 11 and further increase it whenever needed?

StelianMorariu commented 9 years ago

Of course, we could go with the minimum required.

L-Henke commented 9 years ago

We only have 1,21% users with 2.3.3-2.3.7, but why lock out more than necessary.

StelianMorariu commented 9 years ago

Well, api 12 & 13 refer to Honeycomb (which, if you remember, was available only for tablets) and 14 is the very first Ice Cream Sandwich (4.0.0)which got upgraded really quick to 4.0.3 (api 15).

Also, taking a look at some code from the MainActivity, the method to get the back stack entry name was only added in api 14.

I'll create a PR so you can take a look.

Graveen commented 9 years ago

Honestly if we go from 10 to 11 let's directly target API 15 (ICS). At least it'll clearly show what target is aimed.

I can't believe devices running less than API15 are able to decrypt a single image with 512Mb RAM :) <jk, i have not tested>

L-Henke commented 9 years ago

closed by #116