search

SecrecySupportTeam / secrecy

http://forum.xda-developers.com/showthread.php?t=2704486
Apache License 2.0
78 stars 27 forks source link

Intent filter responds to all mime-types, can't handle all types #139

Open vixsomnis opened 9 years ago

vixsomnis commented 9 years ago

For instance, "sharing" a URL from a web browser or raw text to secrecy isn't handled correctly. It neither fails nor adds a file to the vault.

Another example is sharing a contact. If one shares a contact with secrecy and adds it to the vault, the "Adding files" notification will not complete, possibly since secrecy can't remove the contact file.

Is there a graceful way to show an error to the user if secrecy doesn't know how to handle the data?

vixsomnis commented 9 years ago

I think this is actually a bug? You can share anything at all with secrecy, but secrecy can't actually store it.

Doplgangr commented 9 years ago

You've got a point there.

vixsomnis commented 9 years ago

I think the / filter is still necessary, it's just how the file is handled if secrecy doesn't understand it. It just needs to cleanly fail (a visible error). I checked it with a URL shared from a browser and it didn't store any garbage files, so I think all that is needed is the error/warning ("Secrecy could not add your file!").