search

SecretDecks / Documentation

Documentation from seed to clone.
Other
5 stars 9 forks source link

Finish Smart Contracts Drafts #15

Open DanM3rcurius opened 3 years ago

DanM3rcurius commented 3 years ago

Goal

Provide Feedback on THIS DOCUMENT. It should function as the framework for the smart contracts used within the SecretDecks Apps.

Specifications

wlstylr commented 3 years ago

@DanM3rcurius I'm unsure on what type of feedback would provide the most value. Should we be focusing on the format that the contracts are presented, the actions they describe, or both?

The way you have structured the smart contracts in human readable language makes sense to me. Contract A seems to describe both artist onboarding and token creation. In my mind, it makes sense to separate artist onboarding and token creation into separate contracts.

For token creation do we need to address collections vs one-of-a-kind tokens? How would minting Tarot cards look? It seems this could become complicated. Each card is unique but belongs to a deck (collection). Does the artist first create a policy for the deck and then mint each individual Tarot card that belongs to the deck? Can multiple artists contribute to one deck?

Contract B looks good to me. I don't really have any questions other than do we need a separate contract for Owner <-> Buyer, or can the Artist <-> Buyer contract be used in this situation as well? Maybe just a slight modification...

DanM3rcurius commented 3 years ago

From Kat:

You should also think about adding to the contracts for artist permission to use their artwork to publicise the foundation/company, for example use in blasts or blogs etc. If you don't you need to ask them everything time.