Assign n schedule - Githubissues

FungOliver commented 4 months ago

Proof of concept // in development

This PR implements a draggable knockOutTree instead of a list for assignning matches. Saving the order works right now, however, technically properties should be readonly? So what I am doing here is technically undefined behavior? The other solution would be to do emits() and emit() updates up to the parent element.

[ ] refactor/reformat and pull out duplicate code?
[ ] fix match preview in ViewMatchViewArrray in the file ViewKnockoutTreeDraggable
[ ] fix the alignment for 4 player knockoutTrees
[ ] @SecretJ12 why do we need to constantly update in AssignMatchesKnockout with const anFin = sleep(firstUpdate ? 0 : 500). Can't we assume that all teams have been added during match assignment or at least assume that it wouldn't happen concurrently?

SecretJ12 commented 4 months ago

@FungOliver const anFin = sleep(firstUpdate ? 0 : 500) was used for a smother loading animation, don't think it has something to do with reloading

SecretJ12 commented 4 months ago

Like the new version, definitely more reasonable than my previous design

Maybe we could try to align those lines? grafik

Refactoring would be defnitely worth it, also the code in the backend could be simplified a lot

SecretJ12 / Turnierplaner

Assign n schedule #17

Proof of concept // in development