Secretchronicles / TSC

An open source two-dimensional platform game.
https://secretchronicles.org/
GNU General Public License v3.0
205 stars 49 forks source link

Hills Replacements #236

Closed datahead8888 closed 9 years ago

datahead8888 commented 10 years ago

The green_1 graphics at https://github.com/Secretchronicles/TSC/tree/devel/smc/data/pixmaps/hills/green_1 look a lot like Super Mario Bros 3 hills and need a replacement. Ideally we'd want a replacement that gives a similar feel to the player but that does not look like a Mario rip.

Some of the other hills in the pixmaps/hills folder might be worth discussing. If anyone knows of map tiles or other background objects that have this problem, feel free to post them here.

head middle

datahead8888 commented 10 years ago

Here's another: https://github.com/Secretchronicles/TSC/tree/devel/smc/data/pixmaps/hills/light_blue_1

head middle

datahead8888 commented 10 years ago

This background reminds me heavily of a Super Mario World background: https://github.com/Secretchronicles/TSC/blob/devel/smc/data/pixmaps/game/background/blue_hills_1.png

blue_hills_1

datahead8888 commented 10 years ago

Okay...this is the top one on the list now...

https://github.com/Secretchronicles/TSC/blob/devel/smc/data/pixmaps/ground/green_2/hedges/small_2.png

small_2

This one is clearly a reference to Super Mario Bros. 3 and HAS to be changed. The other ones we can discuss (especially the first two), but this Mario 3 reference has to be replaced.

Luiji commented 10 years ago

I think the first two definitely need to have at least the eyes removed, the third can be pulled off as an homage (perhaps), and I definitely concur that the last one needs to change.

Quintus commented 10 years ago

All the clouds.

cloud

cloud

cloud

cloud

cloud

cloud

etc, etc.

Valete, Quintus

DarkAceZ commented 10 years ago

Here are the slightly more lonely, yet just as puffy clouds, without eyes: https://dl.dropboxusercontent.com/u/22806246/SMC/graphics/Clouds.tar.gz

datahead8888 commented 10 years ago

As a thought, we could also try changing the style of the eyes in some cases rather than removing them. We at least need to make sure it doesn't look like a Mario game, of course.

Quintus commented 9 years ago

@DarkAceZ may you want to have a look at removing the eyes from the other stuff (especially hills) mentioned in this issue?

@datahead8888 Improving the graphics later on again is not a problem. When someone comes up with something better, we’ll use it.

Vale, Quintus

DarkAceZ commented 9 years ago

https://dl.dropboxusercontent.com/u/22806246/SMC/graphics/%23236/drafts.tar.gz Some new blind hills. The backdrop one looks kind of bland, now.

Quintus commented 9 years ago

Some new blind hills. The backdrop one looks kind of bland, now.

Thank you for your work! Note that of course improvements to the graphics are possible later always, so this isn’t the final word forever :-). It’s just that we move a away from the Marioeskness we still have too much of.

Vale, Quintus

datahead8888 commented 9 years ago

Yeah, I was going to say we ought to look at something on some objects (eyes or otherwise - maybe something other than hills if eyes) to spice things up. Bugsbane did a pretty good job with that when he put faces on blocks.

This change removes the Mario-ism, though, which helps us move forward.

datahead8888 commented 9 years ago

This one still isn't changed, so I don't think we should close this issue yet: https://github.com/Secretchronicles/TSC/blob/release-2.0.0/tsc/data/pixmaps/ground/green_2/hedges/small_2.png

Alternatively, we could rename this issue and leave it closed, opening a new issue for "Other hill changes".

DarkAceZ commented 9 years ago

There is no SVG that goes with that one, so I think I'll let someone else edit it. I'm magical, but I'd rather not spend too much of my magic on that one.

datahead8888 commented 9 years ago

I just meant we need an open issue in the tracker for it, or it will be forgotten. Thanks for all your edits, @DarkAceZ.

Quintus commented 9 years ago

This one still isn't changed, so I don't think we should close this issue yet:

For 2.0.0, it is enough that has been resolved. It hinders the release if we insist on replacing every single thing. There are a lot of backgrounds for example that still have eyes on hills. I don’t think we want this to stop us now. You can create a new issue and add a "superseded by xxx" comment if you fear we forget about it.

For reference, some PNGs do have XAR files as sources rather than SVGs, for example this one. The file you mentioned doesn’t have sources at all. Personally, I think this small micro hill can just be removed without further impact.

Valete, Quintus

datahead8888 commented 9 years ago

It hinders the release if we insist on replacing every single thing. Personally, I think this small micro hill can just be removed without further impact.

I had assumed we'll have to leave some Mario-isms in the release because we can't reach the artists, but you are correct that removal is another option.

What will happen to levels that are already using it, though? Will they get an error or just have some automatically removed scenery?

Quintus commented 9 years ago

What will happen to levels that are already using it, though? Will they get an error or just have some automatically removed scenery?

In normal gameplay the object will just be missing. In the editor, a string specifying the filename is shown instead. Also, a warning is printed to the console.

Vale, Quintus

Bugsbane commented 9 years ago

Just an idea, for how we could fix a lot of these very quickly:

  1. if I come up with a generic selection of mouths - say 6 - which wouldn't take long at all. Most I could rip from things I've already made. (I already have 3 or 4).
  2. We just open up the SVG's for everything with eyes, delete them and paste in one of the mouths. Possibly choose a new color to match.
  3. Profit! :D

For an example of what I mean, you can see what I did with the new hedge graphics (although I made some other edits to the shape there, but it demonstrates the point).

Yes it wouldn't be perfect, but it would still look better than many graphics we already have in the game, and it would let us remove all of the Mario like "things with eyes" in about an hour, and give us our own look.

Just sayin'

datahead8888 commented 9 years ago

We might need to come to a decision on #298 before redoing all the hills. Whatever gets decided on the hedge ticket is probably going to set a rule or partial rule.

We really need to get a team meeting scheduled soon to discuss stuff like this and bring it all to resolution. We also need to decide on the story, which means I'm going to need to finish reading danfun64's drafts and posting thoughts on them -- I've just been tired out after meeting a research deadline.

Quintus commented 9 years ago

As I indicated, I’m not opposed to the mouths idea. I don’t remember anything like this in other games, and it looks fairly nice.

Valete, Quintus