Replace level finish song

[Quintus]

We probably need another level finish song.

Valete, Quintus

[datahead8888]

It might be interesting if long term we had multiple level end songs, each corresponding to a different kind of level. Donkey Kong Country 2 did this, and it worked really well. With our own themes, we'd still seem unique.

For now, we just need a generic song that we can use in all levels so that we don't have the Mario World remix theme. Personally, I'd go for something a little less guitar/banjo oriented, but that's just me.

I would guess the new song probably needs to be about the same length as the old one, but I'm open to other ideas.

I've emailed Johan on it in case he's available to take a look.

[Quintus]

Also, /cc @RedFT.

Vale, Quintus

[datahead8888]

@sydneyjd - could you look on game music websites and see if you can find a short end level theme that we could borrow for a while? It would need to have a license that works with TSC -- Quintus will have to double check the license once we find the song.

[sydneyjd]

Um, i could, but i dont know of any sites.

[datahead8888]

Um, i could, but i dont know of any sites.

It'd involve some googling. Unfortunately, I can't do much looking because I'm just about in finals week and have research deadlines imminent, too. If anyone else can post some links, too, it'd be appreciated.

[datahead8888]

Actually, @sydneyjd - this site has some game music - http://opengameart.org/ I think @Quintus has already looked at their license when we discussed some other pieces, but he can confirm. Thank you for offering to look.

[Quintus]

datahead8888 notifications@github.com writes:

Actually, @sydneyjd - this site has some game music - http://opengameart.org/ I think @Quintus has already looked at their license when we discussed some other pieces, but he can confirm.

OpenGameArt allows each artist to choose his license terms separately and invidually for each piece they upload; hence you have to check the licensing separately on each asset you find.

Vale, Quintus

[datahead8888]

Johan (Jobromedia) had published these on opengameart.org: http://opengameart.org/content/level-finish-fanfares

I remember him giving us a link to this to check out. The license on these is "CC-By-SA-3.0".

These probably are used in the Open Surge game. Although we might feel like we're losing originality by using music from another game, it's a whole lot better than using remixes of Mario music. The songs are good, though, and there are probably a lot of other people using them.

Does anyone have any thoughts on putting one or some of these in the release?

[Quintus]

Johan (Jobromedia) had published these on opengameart.org:

These are... awesome. Marvelous. Wonderful.

Does anyone have any thoughts on putting one or some of these in the release?

The songs are meant to be used in an incremental order, i.e. the better you do the level, the more appreciative the song. Currently, the game only supports one single level ending song, so it would only be possible to include the "E" song. However, I definitely like the idea of having different songs depending on how you do the level. We already have an easy measure for this: The points. We should allow the level designer to specify the point numbers at which one of the D, E, C, B, A, AA, and AAA songs is played when reached. These numbers would have to be relative to the number of points the player had when entering the level obviously. This should be really as easy as adding a new page to the level settings editor that specifies the point borders. If none are specified, just always play the "E" music; this also preserves backward-compatibility accidentally.

CC-BY-SA 3.0 as the license is fine. We can include these from a legal point.

Vale, Quintus

[sydneyjd]

Awesome idea!!!! :) I like it.

[datahead8888]

I labeled this as a blocker task because it is a derivative of the Mario music replacement task (#97), which is also blocker. We've found a replacement and thus need to make use of it (we would probably only use one song for now).

[datahead8888]

For now I'm uploading a screenshot of the licensing for these songs to this ticket. Date obtained: Jan 1, 2015

[datahead8888]

I've added all the versions of the level ending music to the release branch and changed the game code to use courseclear_A.ogg. This has been pushed to the release-2.0.0 branch.

A couple future thoughts:

• We might make the music begin immediately playing when the player takes an exit rather than wait until the graphic effect is finished
• Some of the songs have a slight pause at the end. This may be fine for level ending music, but we may think about whether we want to trim them a little (or at least configure them differently once we change TSC so that it can auto-loop songs and start and begin a song at any point).