search

Secretchronicles / TSC

An open source two-dimensional platform game.
https://secretchronicles.org/
GNU General Public License v3.0
205 stars 49 forks source link

Replace Super-Mario-World-style dying music... #260

Closed datahead8888 closed 9 years ago

datahead8888 commented 9 years ago

When you die in a level, a remix of the Super Mario World dying music is played. We will probably have to request a new song from a musician, unless we're lucky enough that someone has already written a tune like this.

Also, where is the music file for this? I have never been able to find it...

datahead8888 commented 9 years ago

Also, when you die, the dying music is still finishing its playing when the next screen loads, causing both pieces of music to be playing for a moment. We probably need to increase the pause a little bit after you die before the next screen loads.

It won't make sense to do this, however, until we find a replacement for this piece of music - this will ensure we know the timing to use before switching to the next screen.

I could file a bug (or other ticket) for this timing issue if this works well, though we'd need to note the dependency on this music replacement ticket.

Quintus commented 9 years ago

Also, where is the music file for this? I have never been able to find it...

It’s not a music, it’s a sound. https://github.com/Secretchronicles/TSC/blob/v2.0.0-beta6/tsc/data/sounds/player/dead.ogg

Vale, Quintus

datahead8888 commented 9 years ago

It’s not a music, it’s a sound.

As part of this change (once we actually have new music for it), might we consider moving this to the music folder? It plays musical notes, so music seems like a better category. It's also confusing to have level end music then have a dying "sound".

Luiji commented 9 years ago

@datahead8888 There's a technical difference between music and sound, generally boiling down to whether it's loaded in full (sound) or it's streamed (music).

For such a short sample, it should remain classified as a sound.

datahead8888 commented 9 years ago

loaded in full (sound) or it's streamed (music)

What do you mean by loaded in full or streamed? Music obviously can repeat whereas sounds normally do not, but I wanted to make sure I understood your terminology.

Quintus commented 9 years ago

What do you mean by loaded in full or streamed?

Loaded in full: The entire file is read into RAM before playing. Streamed: Only parts of the file are loaded into RAM, played, discarded, then the next parts are loaded into RAM. If you for example have a music file with 10 GiB (ok, unrealistic, but for the sake of example), you can’t load it in full -- most people don’t have the necessary RAM. You can only stream the file.

Vale, Quintus

datahead8888 commented 9 years ago

cc @Aakburns, @RedFT

Aakburns commented 9 years ago

I'll see what I can come up with for a dying 'sound'. In either case it will be a short piece of music, not just a death noise.

For the moment, I'll just be funny and attach a death sound I made years ago. http://arikburns.com/download/DeathSound1.wav

datahead8888 commented 9 years ago

I'll see what I can come up with for a dying 'sound'.

Thanks, @Aakburns. This one's probably a little faster to do than the others given that it's short.

In either case it will be a short piece of music, not just a death noise.

...hence our discussion on using the music or sound folder :P I'll have to post back on that later when I get some more time to think on Luiji's arguments.

Luiji commented 9 years ago

Whether or not it should be classified as sound or music, for technical reasons should resolve to the question of whether it's short enough to practically be kept in memory at all times, as with all other sound effects.

It could be practical to classify the death music as music due to the fact that it plays in place of other music and lasts a fair length of time, and shouldn't happen at as high of a rate as other sound effects.

datahead8888 commented 9 years ago

Silen has volunteered for this task. See: http://gamejolt.com/community/forums/topics/secret-chronicles-urgent-need-for-music/5645/#post-36339

datahead8888 commented 9 years ago

Silensir has made a licensing statement for the dying music. He did technically make the mistake of mistyping the URL (because he saw a slightly abbreviated form by sound cloud using .. to remove part of the URL when viewed). I would assume this is sufficient, but let me know if there are any concerns. Here is a screenshot of the confirmation:

screenshot from 2015-03-03 17 29 07

Quintus commented 9 years ago

This is sufficient.

Vale, Quintus

Quintus commented 9 years ago

See 66c3ba91a329d98c34408fee6d2eaef40a0b7b31.

Vale, Quintus