Secretchronicles / TSC

An open source two-dimensional platform game.
https://secretchronicles.org/
GNU General Public License v3.0
205 stars 49 forks source link

New Secret Chronicles Icon... #263

Closed datahead8888 closed 9 years ago

datahead8888 commented 9 years ago

The current desktoip icon has the letters "SMC" on it in the graphics. It needs to be changed to "TSC".

cc @DarkAceZ and @sydneyjd

sydneyjd commented 9 years ago

@datahead8888 I will do that, if i know what the original SMC one looks like, and what your expecting in the TSC remake.

Quintus commented 9 years ago

@sydneyjd Here you can view the old SMC icon in extra-large: https://github.com/Secretchronicles

Vale, Quintus

sydneyjd commented 9 years ago

Oh, ok. Will see what i can do. DOes it have to be SVG format? @Quintus @datahead8888 ?

sydneyjd commented 9 years ago

Also, what is TSC's font?

sydneyjd commented 9 years ago

Haha, i know gimp quite well, and inkscape looks a little intimidating. ;)

Quintus commented 9 years ago

Oes it have to be SVG format?

Yes.

Also, what is TSC's font?

No specific one currently. This is something for discussion, especially as it would be nice to use a consistent font in both the game, and on the website.

inkscape looks a little intimidating.

Inkscape basics are quite easy. Just try around a bit. Advanced usage is something really tough, though.

Vale, Quintus

sydneyjd commented 9 years ago

Ok, wel lthen, what font Should i use? Or what have been some that have been used before? I use sneakerhead BTN for my church, and i think that might fit. http://www.myfonts.com/fonts/btn/sneakerhead-btn/

sydneyjd commented 9 years ago

Here is what i have so far ( With a little help from Quintus ) @datahead8888 and everyone else, what do you think? I used the Sneakerhead_BTN font. test1

datahead8888 commented 9 years ago

Nice! Leaving the Maryo image out for now is a good idea! Just be sure to use layers in case we need to experiment again down the line.

Should we include a gem in the picture, or do we want gems to be iconic (pun intended)?

sydneyjd commented 9 years ago

Good question. That might be a nice adition. What do you think @Quintus ? I will write up another one with a gem a min.

datahead8888 commented 9 years ago

If you put the gem in its own layer in the SVG, we can add or remove it as needed anytime. @Luiji or @DarkAceZ - what do you think about the gem idea?

sydneyjd commented 9 years ago

Red or blue? And should it be right under the "TSC" logo?

sydneyjd commented 9 years ago

Also, is there a coin SVG @Quintus and @datahead8888 ? Ive searched through the whole /drafts directory and not found one. :s

datahead8888 commented 9 years ago

Also, is there a coin SVG

We decided to replace coins with gems as part of our efforts to stop being a Mario clone. I'm not sure if the coins were completely removed from the drafts, but I suspect they were.

I would probably try putting the gem to the right side's center. We've have to see it to know how well that works, though.

sydneyjd commented 9 years ago

Oh, here is one with it in the center. I only had a .png to work with for the coin :s test2

datahead8888 commented 9 years ago

Actually I meant the right's center, which would move it to the right a bit. This way the gem is not the biggest focus.

sydneyjd commented 9 years ago

Oh, ok, let me fix.

sydneyjd commented 9 years ago

test2

datahead8888 commented 9 years ago

Sorry, I meant even further right, above the horizontal center of the furball. I guess it's hard to put into words.

Neither way is wrong; it's just a possible design to consider.

sydneyjd commented 9 years ago

Ok. ;) Now it looks like he has it spinning on his head IMO :P test2

datahead8888 commented 9 years ago

Now it looks like he has it spinning on his head IMO

Yeah, you have a good point there. The second from the last one you did is probably the best choice. We could see what everyone else thinks in the next day, too.

Quintus commented 9 years ago

Also, is there a coin SVG

What the...? I was convinced @Bugsbane added the jewel SVGs to the drafts/ folder. Skimming through the commit log it appears he didn’t. We need to get hold of them/him quickly then, we don’t want to have graphics in the game that miss the SVGs. @Bugsbane?

On the logo, I personally like the version with the jewel between Krush and Furball more.

Vale, Quintus

sydneyjd commented 9 years ago

@Bugsbane can we please get some throughput?

sydneyjd commented 9 years ago

What happened to Bugsbane????

datahead8888 commented 9 years ago

What happened to Bugsbane????

Bugsbane has been out for a while. We're not sure when he might be back.

sydneyjd commented 9 years ago

@datahead8888 have you been able to locate a svg for the jewel?

Quintus commented 9 years ago

have you been able to locate a svg for the jewel?

@Bugsbane has created a Blender 3D model instead of an SVG. It is in the repository. Blender should be able to export this in any size, maybe even as an SVG, I don’t know.

Vale, Quintus

sydneyjd commented 9 years ago

Hmm, it apears that blender cannot export to SVG directly. I have posted the SVG of the icon and a .PNG of it on the forum. That is using the .PNG jewel. :s

sydneyjd commented 9 years ago

FYI the icon is uploaded here. http://forum.secretchronicles.de/topics/152 Im excited to see how it will look installed :)

Quintus commented 9 years ago

I think the icon is quite good now; if you want, you can create optimised versions with lesser elements, e.g. for the 16x16 pixels version. In any case: @sydneyjd, could you please submit your changes as a Pull Request? In that PR:

Vale, Quintus

datahead8888 commented 9 years ago

@sydneyjd, could you please submit your changes as a Pull Request?

He posted it on the forums. He told me he would rather submit through the forums and have developers commit it through git. This is a good submission method for a lot of people.

@sydneyjd - when you get a chance, see if you can create versions in the other dimensions Quintus gave. You can submit them through the forums, too.

Quintus commented 9 years ago

This is a good submission method for a lot of people.

Depends. With a PR, he is in the commit log. If one of us developers commits it, his name will not show up there as a commiter. I don’t want people to be restricted to GitHub for contributions, though. Maybe as a compromise use $ git format-patch and submit the resulting commitfile? This is an easy way to create contributions without having to figure out how to get a Git repository up and running that is not on GitHub.

Vale, Quintus

Quintus commented 9 years ago

Addendum: With $ git format-patch you get a .patch file that is basically a regular .diff, just with Git commit identification included. With $ git am the file can be read in and is inserted into the history as a regular commit.

Vale, Quintus

datahead8888 commented 9 years ago

Depends. With a PR, he is in the commit log. If one of us developers commits it, his name will not show up there as a commiter. I don’t want people to be restricted to GitHub for contributions, though.

git (not even with github) may seem a bit too technical for many people -- it's generally something programmers learn, and in many cases non programmers don't learn it. If someone such as Bugsbane feels comfortable using it and is willing to learn how, it certainly helps the project, but I think we should still be willing to accept contributions from people through the forums as was done in the old SMC. I think Sydney was a little weary of using it to change assets rather than just pull them.

I saw some of your commits had something in them that said you were doing it for Bugsbane. Might this be an option? I'm pretty tied up with school and, unfortunately, cannot work on getting this into github myself right now. In the long run, we really will need a larger number of contributors in order to keep one person from doing all the commits from the forums (which so far has almost been entirely you, Quintus).

As for the git format patch suggestion, @sydneyjd - do you think this is something you might feel good with?

Quintus commented 9 years ago

I saw some of your commits had something in them that said you were doing it for Bugsbane.

It is an option, yes, but it isn’t ideal, because the metadata is missing. The commit is assigned to me rather than to the person who deserves it. And I think you meant Aakburns rather than Bugsbane; I’ve commited a number of music pieces to the game for him.

but I think we should still be willing to accept contributions from people through the forums as was done in the old SMC

Agreed. But in this case I know sydney has already been using Git, so rephrasing his submission into something Git can understand shouldn’t be too difficult for him :-). But of course, I (or anyone else with write access) am continuing to commit assets to the repository for people who can’t. In this case it is required to name the person who create the asset, though, to prevent confusion when someone reads the commit log.

Vale, Quintus

Quintus commented 9 years ago

Hey -- I’ve just found that Git has actually taken care of this problem. Excerpt from git help commit:

   --author=<author>
     Override the commit author. Specify an explicit author using the standard A U Thor
     <author@example.com> format. Otherwise <author> is assumed to be a pattern and is used to
     search for an existing commit by that author (i.e. rev-list --all -i --author=<author>);
     the commit author is then copied from the first such commit found.

Great. So forget what I said a few minutes ago -- use that option when you commit for someone else. This makes the metadata correct.

Vale, Quintus

datahead8888 commented 9 years ago

And I think you meant Aakburns rather than Bugsbane; I’ve commited a number of music pieces to the game for him.

No, I meant Bugsbane. See: f01687ae7456e8295782a99cd89e1a9629b4aa99

Agreed. But in this case I know sydney has already been using Git, so rephrasing his submission into something Git can understand shouldn’t be too difficult for him :-). But of course, I (or anyone else with write access) am continuing to commit assets to the repository for people who can’t. In this case it is required to name the person who create the asset, though, to prevent confusion when someone reads the commit log.

It's up to Sydney what he feels comfortable with; I just don't want to pressure him into doing it is all.

Quintus commented 9 years ago

No, I meant Bugsbane. See: f01687a

That commit is assigned to Bugsbane, as can be seen from how GitHub displays that commit’s page. What you see here is a special form of commit; it usually happens when you git cherry-pick a commit from someone else or merge some else’s branch. That commit has been originally created by that person, but technically, you re-add it, and this is also recorded. As a result, you get this double metadata that says who was the original author and who was the guy who re-commited that commit at a different place in the Git history.

It's up to Sydney what he feels comfortable with; I just don't want to pressure him into doing it is all.

Yes.

Vale, Quintus

datahead8888 commented 9 years ago

This is a blocker because we can't release with an icon that says "SMC". It is already finished in the release branch, though.

datahead8888 commented 9 years ago

...by the way, I noticed we need to update the icon (and game title) at https://github.com/Secretchronicles

Quintus commented 9 years ago

This is a blocker because we can't release with an icon that says "SMC". It is already finished in the release branch, though

And because it is finished in the release branch already, adding the blocker label here is nonsense.

Vale, Quintus