Weird Pipe "ReWarp" - Githubissues

Secretchronicles / TSC

An open source two-dimensional platform game.

https://secretchronicles.org/

GNU General Public License v3.0

205 stars 49 forks source link

Weird Pipe "ReWarp" #290

Open datahead8888 opened 9 years ago

datahead8888 commented 9 years ago

This bug seemed to start happening after some of the recent pipe changes in release 2.0. For many pipes in my Desert Break In level, if I take them, when I come out the other end, it pauses, and then Alex is warped back to the same pipe and starts coming out again.

Steps to reproduce:

Load this simplified level: https://drive.google.com/open?id=0B6YSsocq3-cWTXZsVHFRTlR6TWs&authuser=0
Enter the pipe toward the bottom with the ice mushroom on it
When you come out the other end in the pipe to the upper left, you should see Alex start coming out, the game pause for a second, and then see him start coming out the pipe again...

It looks like a bug, but I've waited to categorize it until someone else offers their thoughts on it...

Quintus commented 9 years ago

if I take them, when I come out the other end, it pauses, and then Alex is warped back to the same pipe and starts coming out again.

The "comes out of a pipe twice" bug has already been present in earlier versions of the game; I’ve seen related reports in the original SMC forums. It has something to do with the positioning of the level exits and entries, especially with their collision rectangle. The pipe replacement commits changed the collision rectangle of the pipe endings (it is quite a bit smaller now), so it is likely that this causes the bug to appear.

I will look into your example level later, but note that until the new year I’ve a more limited timeframe available.

Vale, Quintus

datahead8888 commented 9 years ago

but note that until the new year I’ve a more limited timeframe available

No one can realistically expect you to be spending vast amounts of time working on TSC over the holidays... Thank you for offering to look into it.

datahead8888 commented 9 years ago

I realized the information in this ticket is non-conclusive right now. This bug stopped occurring in the game when we restored the pipes to their original size. However, the original bug that causes rewarps should happen in theory if the commit that changes the size of pipes originally is restored again. Thus this ticket represents the underlying problem. It might become more of an issue when we try to add things like logs, etc, as pipe replacements later.

datahead8888 commented 7 years ago

This bug stopped occurring in the game when we restored the pipes to their original size. However, the original bug that causes rewarps should happen in theory if the commit that changes the size of pipes originally is restored again.

I'm changing this to the "legacy code" label -- the bug is not currently occurring, so "Bug" is misleading. Since it is an issue in the implementation of the code with its configurations, "Legacy Code" is much more meaningful.