Coding style

[Quintus]

@brianvanderburg2 brought up the coding style question in the forums. Personally, I hate tabs. And I hate if and for braces on new lines (this is only OK for functions, classes, namespaces, i.e. large elements). I also prefer an indentation of 2 spaces.

I’ve started a coding styleguide for SMC here. I would love to hear comments on that, but note it’s not complete yet.

Valete, Quintus

[Quintus]

-- VOTE FINAL RESULTS --

• K&R Stroustrup variant: 2 votes
• Allman style: 2 votes

---

This means we have a winner now. As per the remis rule I stated in the call for votes:

In case no style gets the most votes, the result from the previous vote will be used as the final result (i.e. K&R Stroustrup variant).

The style we will use therefore is the K&R Stroustrup variant.

I will run an autoformatter on SMC’s codebase as soon as possible. For the finer details that are not covered by the Stroustrup style or are different from it, I will look through SMC’s codebase and write them up in a styleguide. See here for the full Stroustrup C++ styleguide.

For future votes, I will also codify the voting procedure. This will prevent confusion on how votes are made.

Valete, Quintus

[datahead8888]

As was suggested previously, we probably should be a bit liberal in how we handle this with PR's (even for repeat contributors). Quintus's idea to politely suggest it in code reviews is probably good; we probably shouldn't force someone to do it unless it's causing serious hassles for everyone else. As Luigi said, we can always work additional tasks to run the formatter on the code later.