search

Secretmapper / react-image-annotation

An infinitely customizable image annotation library built on React
https://secretmapper.github.io/react-image-annotation/
MIT License
329 stars 135 forks source link

Adding type definitions for Typescript #12

Closed danilofuchs closed 5 years ago

danilofuchs commented 5 years ago

Types generated based on documentation, propTypes and real-case usage. Has been tested and refined. Some types are unclear to define, so they are noted as "any"

ptcampbell commented 5 years ago

Thanks for this @danilofuchs!

Could we get eyes on this @Secretmapper?

Secretmapper commented 5 years ago

Thanks for the PR! @danilofuchs

rnmp commented 4 years ago

Thanks @danilofuchs for writing the types. Now, are we all aware that these don't make it to the final build? My only solution atm is to just copy/paste what @danilofuchs created into a custom file?

danilofuchs commented 4 years ago

@rnmp I think I forgot to add src/types/index.d.ts into the published files array. I am currently not developing for this library as much as when I initially did this work, so it may be outdated.

rnmp commented 4 years ago

@danilofuchs yeah, I figured. That's okay though, I had created some of my own so it was easier to just copy/paste what you had and expand from there!