Secrets-of-Sosaria / World

Code repository for the Secrets of Sosaria world
GNU General Public License v2.0
11 stars 9 forks source link

[Bug] Scepters and staves should have spell channeling #102

Open cpzjunior opened 2 weeks ago

cpzjunior commented 2 weeks ago

Like wands, scepters and staves are weapons used primarily by wizards. However, they do not have spell channeling by default. Whenever I use a spell, they are unequipped, which makes it difficult for my wizard to play, since I am forced to equip them again every time.

creiht commented 1 week ago

Looking at the code, it is evident that these items were created for wizards (file name is WizardStaff.cs), so I would be on board with making a change like this, but also open to hearing other's opinions here.

I also noticed that there are no requirements to be a wizard to use them or their special ability. So I guess the question also comes up, should some level of magic skill be required to use them, or the damage leveled by their magic skill?

Kynick commented 6 days ago

I've always thought it a bit silly that these dont have SC by default. its the reason Ive been a punching elementalist instead of using them

mz1193 commented 10 hours ago

Looking at the code, it is evident that these items were created for wizards (file name is WizardStaff.cs), so I would be on board with making a change like this, but also open to hearing other's opinions here.

I also noticed that there are no requirements to be a wizard to use them or their special ability. So I guess the question also comes up, should some level of magic skill be required to use them, or the damage leveled by their magic skill?

I've been working on this a bit today, and interestingly enough, these weapons do already actually complain about you "not being a powerful enough mage" if you attempt to equip them on a low-skilled character. However, I don't see references to it in this specific file, so I wonder if it's pulling from somewhere else?

In any case, I figured out how to add spell channeling to these weapon types and will be submitting a PR for that shortly!

mz1193 commented 10 hours ago

PR is submitted, but I would appreciate some local testing from those who play characters like this. I've only done some cursory testing locally on my end with a very basic character. It's a very simple change and should just work, but you never know!