Secrets-of-Sosaria / World

Code repository for the Secrets of Sosaria world
GNU General Public License v2.0
11 stars 10 forks source link

[bug] [password command allow the player to softlock themselves out of the account #39

Closed EstelMatiazi closed 1 month ago

EstelMatiazi commented 1 month ago

currently, there's no ingame check for password length when a player tries to reset it with the [password command, and the game launcher has a cap of 16 characters in the password field, so, if a player sets a password longer than 16 characters, it will require an admin reset for it to be able to log in the game again. If the player changes the admin account password for something longer than 16 characters, then they are out of luck and have to fiddle with the accounts.xml in order to join their world again.

image

image

the password updates suscefully.

image

password caps at 16 characters.

Proposed solution: add a check for string length and give the player a message when they try to change the password for something that will lock them out of the game.