Fix firstrun and firstsync

Secure-Compliance-Solutions-LLC / GVM-Docker

Greenbone Vulnerability Management Docker Image with OpenVAS

https://securecompliance.gitbook.io/projects/

MIT License

248 stars 91 forks source link

Fix firstrun and firstsync #179

Closed Masaya-A closed 3 years ago

austinsonger commented 3 years ago

@Masaya-A please provide reasoning of the pull request.

Masaya-A commented 3 years ago

The original paths are a root directory and are not a persistent directory (using --volume gvm-data:/data). So, when updating the container, those files will be deleted and some commands which won't be needed will run again.

austinsonger commented 3 years ago

Resolves #187

grantemsley commented 3 years ago

That PR also moves firstrun which sets up symlinks and users for a fresh container. I think those steps still need to be done even if data already exists.

Masaya-A commented 3 years ago

@grantemsley You are correct! Thank you. I've created a new PR #191 to revert them.