Closed alexandrefresnais closed 3 years ago
This PR makes the sync-all.sh script executable directly by the gvm user. The supervisor conf is running the GVMUpdate job as gvm user and thus, the feed is never updated due to su errors. See https://github.com/Secure-Compliance-Solutions-LLC/GVM-Docker/issues/293
sync-all.sh
gvm
su
I did not want to make the job run as root for good security practices reasons. So instead, I check whether or not the user is root or gvm and adapt the update commands.
root
Resolves #293
https://github.com/Secure-Compliance-Solutions-LLC/GVM-Docker/issues/293
The sync-all.sh script is working when executed by gvm user.
Summary
This PR makes the
sync-all.sh
script executable directly by thegvm
user. The supervisor conf is running the GVMUpdate job asgvm
user and thus, the feed is never updated due tosu
errors. See https://github.com/Secure-Compliance-Solutions-LLC/GVM-Docker/issues/293I did not want to make the job run as root for good security practices reasons. So instead, I check whether or not the user is
root
orgvm
and adapt the update commands.Fixed Bug/Issues solved:
Resolves #293
https://github.com/Secure-Compliance-Solutions-LLC/GVM-Docker/issues/293
Breaking Changes:
The
sync-all.sh
script is working when executed bygvm
user.