search

SecureBrain / ruby_apk

analyzing android apk library for ruby
MIT License
83 stars 52 forks source link

Boolean attributes in manifest #17

Closed obolton closed 11 years ago

obolton commented 11 years ago

Hi,

Thank you for creating this useful library.

I think there is an issue with the way boolean attributes are parsed from the manifest file. It seems that true and false are parsed the wrong way around. For example, if AndroidManifest.xml has this element:

<uses-feature android:name='android.hardware.touchscreen' android:required='false'/>

Then when I call manifest.to_xml the output shows this, instead:

<uses-feature android:name='android.hardware.touchscreen' android:required='true'/>

masatanish commented 11 years ago

Hi, Thank you for reporting.

Which version do you use? I once had the same issue (#7). And it's fixed at v0.5.1. If you use newer than v0.5.1, I think it's different issue from previous one. Could you upload AndroidManifest.xml to somewhere? Then I'll investigate it.

obolton commented 11 years ago

Hi,

I'm using version 0.6.0. Here's a link to a zip file which contains an AndroidManifest.xml like the one mentioned.

http://cl.ly/1f3z0L3j140v

Thanks

masatanish commented 11 years ago

Thank you for sending the file.

I've investigated it. And I noticed the modification on #7 is wrong. ruby_apk sets converse value into boolean attributes. Maybe other boolean attributes are also wrong.

I'll fix.

obolton commented 11 years ago

Thanks - much appreciated.