search

SecureBrain / ruby_apk

analyzing android apk library for ruby
MIT License
83 stars 52 forks source link

added mutf-8 (modified utf-8) support #21

Closed bearmini closed 10 years ago

bearmini commented 10 years ago

hi,

Each string in string_data_item is encoded by MUTF-8 (Modified UTF-8). The MUT-8 strings should be converted into UTF-8 so that the strings can be handled properly by Ruby scripts.

masatanish commented 10 years ago

Hi bearmini,

Thank you for your suggestion. I'll confirm the specification of MUTF-8 and review your PR.

masatanish commented 10 years ago

I found rspec is failed in ruby 1.9.3. https://travis-ci.org/SecureBrain/ruby_apk/jobs/13794734

multi-bytes charactors are used in your test code. I think you need append an encoding comment to top of the file.

# encoding: utf-8
bearmini commented 10 years ago

Hi,

I have replaced the string literals with \u{} escape sequences.

masatanish commented 10 years ago

Hi bearmini,

I've merged your PR. Your blog helps me understand MUTF-8.

Thanks.