SecureSECO / SearchSECOController

GNU Affero General Public License v3.0
6 stars 8 forks source link

Loguru caught a signal: SIGSEGV #37

Closed rowins closed 1 year ago

rowins commented 1 year ago

When doing a check on a test repository (https://github.com/rowins/test) with methods that's in the database, I get the error 'SIGSEGV'

2022-10-06 14:48:16.448 (  31.243s) [controller      ]         networking.cpp:101      1| Listening for a database response
2022-10-06 14:48:31.558 (  46.353s) [controller      ]         networking.cpp:118      1| Receiving 128 bytes
2022-10-06 14:48:31.558 (  46.353s) [controller      ]         networking.cpp:118      1| Receiving 128 bytes
2022-10-06 14:48:31.558 (  46.353s) [controller      ]         networking.cpp:118      1| Receiving 100 bytes
2022-10-06 14:48:31.558 (  46.353s) [controller      ]         networking.cpp:129      1| Received data from database: 200
1035848247?1227548924000?eca35bf3d6abc94ccb46f244c5e3ac289c3396ee?GNU General Public License v2.0?mangos?https://github.com/scamp/mangos?e6f42475-830d-ee5e-57fb-40936a03f285?1
1035038565?1258196453000?f9f4dda6e2ad1043cebb996f19667182088f83c1?GNU General Public License v2.0?mangos?https://github.com/gcore/mangos?a9961275-78c0-cc84-18e7-29fde5e8e4ef?1

2022-10-06 14:48:31.558 (  46.353s) [controller      ]   databaseRequests.cpp:227      1| Database request successful

Loguru caught a signal: SIGSEGV
Stack trace:
11      0x5580883fd93e ./controller/build/searchseco(+0x4e93e) [0x5580883fd93e]
10      0x7fc4283e2083 __libc_start_main + 243
9       0x5580883fda78 ./controller/build/searchseco(+0x4ea78) [0x5580883fda78]
8       0x5580883fde84 ./controller/build/searchseco(+0x4ee84) [0x5580883fde84]
7       0x558088433f9d ./controller/build/searchseco(+0x84f9d) [0x558088433f9d]
6       0x55808842c9c0 ./controller/build/searchseco(+0x7d9c0) [0x55808842c9c0]
5       0x558088408c5d ./controller/build/searchseco(+0x59c5d) [0x558088408c5d]
4       0x55808840a54b ./controller/build/searchseco(+0x5b54b) [0x55808840a54b]
3       0x55808840ec30 std::string std::operator+<char, std::char_traits<char> >(std::string&&, std::string const&) + 43
2       0x5580884714f7 std::string::append(std::string const&) + 33
1       0x558088470e24 std::string::size() const + 16
0       0x7fc4285c4420 /lib/x86_64-linux-gnu/libpthread.so.0(+0x14420) [0x7fc4285c4420]
2022-10-06 14:48:31.564 (  46.359s) [controller      ]                       :0     FATL| Signal: SIGSEGV
slingerbv commented 1 year ago

One of the many DB bugs. What is going on? Either way: SecureSECOController should gracefully exit, not like this.

rowins commented 1 year ago

@rowins , can you please describe your system and the steps you'd taken?

OS, architecture (e.g. ubuntu-20.04 amd64)

and how you build and executed, ideally mention the exact cli instructions. you used.

git checkout repo/branch
cmake 
... etc.

When I encouter this issie, I was using Docker for Windows on Windows 11. Using the command line (Change and ): docker run --name controller-container --entrypoint="./controller/build/searchseco" -e "github_token=<github_token>" -e "worker_name=<worker_name>" searchseco/controller check https://github.com/rowins/test

That's all, we were also using this within Github Actions through ubuntu, but there arises a different problem, so I cannot reproduce that now.

rowins commented 1 year ago

@rowins , is this a regression (it did work previously but then suddenly stopped working)?

Since I am working with this, this didn't work.

rowins commented 1 year ago

Since I am working with this

ok, when did you start working with this?

Around 15 sept, so not very long ago.

slingerbv commented 1 year ago

Good question. Big projects would time out, but small projects (up to around 1000 files) were no problem until the previous developer quit. I don't know what has been happening recently, but the card house really came crashing down.

On Sat, Oct 15, 2022 at 8:42 PM abebeos @.***> wrote:

@slingerbv https://github.com/slingerbv , was the system operational when the previous developers stopped work? Nothing wrong, if not, but you need to clarify this, e.g. by stating prominently that the status is "Proof of Concept - Not for Production Use".

Everything points towards the need for SecureSECO/void#6 https://github.com/SecureSECO/void/issues/6 (executed mainly by one senior-grade dev). Once the overall project is more stable, low-budget bounties targeting junior-devs can workout fine.

— Reply to this email directly, view it on GitHub https://github.com/SecureSECO/SearchSECOController/issues/37#issuecomment-1279805565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAERHLFPCJDEJCIVE6LYUE3WDL3KDANCNFSM6AAAAAAQ6S7PHE . You are receiving this because you were mentioned.Message ID: @.***>

-- dr. Slinger Jansen (Roijackers) Do you want to secure software ecosystems https://secureseco.org/ with us? Software Production Research Group https://www.uu.nl/en/research/software-systems/organization-and-information , Utrecht University http://www.slingerjansen.nl +31 6 19 884 880 book me through YouCanBook.me http://slingerroijackers.YouCanBook.me

slingerbv commented 1 year ago

Confirm, but frustrated with Gitcoin because payments no longer going through. Please contact me for next steps by email.

rowins commented 1 year ago

(@rowins , just realized you're in the crossfire. All good, your feedback was pleasant, both, in speed and quality)

No problem, thankyou!

ghost commented 1 year ago

@rowins , the updated docker image (i guess https://hub.docker.com/u/searchseco) should not(!) crash, though it should report db errors (the db issue is tracked here: SecureSECO/SearchSECOController#66)

Can you please verify on your machine that you're crash-less (ensure docker fetches the updated image)?

rowins commented 1 year ago

@rowins , the updated docker image (i guess https://hub.docker.com/u/searchseco) should not(!) crash, though it should report db errors (the db issue is tracked here: SecureSECO/void#10)

Can you please verify on your machine that you're crash-less (ensure docker fetches the updated image)?

Indeed, it gives only DB error E403, it doesn't crash anymore.

ghost commented 1 year ago

Ok, very nice.

@slingerbv

This is a good example why the build-system rework is needed:

=> this issue/bug behaves differently (on windows / ubuntu / docker) => total debugging nightmare, if not processed carefully

Follow ups

ghost commented 1 year ago

@rowins , it should work now, E403 was fixed within SecureSECO/SearchSECOController#66.

rowins commented 1 year ago

@rowins , it should work now, E403 was fixed within SecureSECO/SearchSECOController#66.

I see it, perfect. Thankyou!