Security-Tools-Alliance / rengine-ng

reNgine-ng is an automated reconnaissance framework for web applications with a focus on highly configurable streamlined recon process via Engines, recon data correlation and organization, continuous monitoring, backed by a database, and simple yet intuitive User Interface.
GNU General Public License v3.0
70 stars 12 forks source link

bug(make): Improve Makefile to detect Docker Compose v1 and sudo usage #203

Closed psyray closed 3 weeks ago

psyray commented 2 months ago

Current Behavior

When user does not put sudo before launching make command, docker compose is not correctly detected and fallback is to use docker-compose. We must improve this part to detect that sudo is missing and stop install with a warning message. And there should be no automatic fallback to docker-compose, existence must be detected first

Also Docker Compose version must be detected If v1 is detected make must exit and display a message to the user regarding Docker Compose upgrade to v2

image image image

Expected Behavior

Install should stop if docker compose or docker-compose is missing and if Docker Compose version is under v2

Steps To Reproduce

  1. Run make file without sudo
  2. Run make with Docker Compose v1 installed

Environment

- reNgine: 2.1.0
- OS: ubuntu 24.04 LTS
- Python: 3.10
- Docker Engine: 24.0.7
- Docker Compose: 1.29.0
- Browser: NA

Anything else?

No response

Acknowledgements

psyray commented 3 weeks ago

Fixed by #211