Security-Tools-Alliance / rengine-ng

reNgine-ng is an automated reconnaissance framework for web applications with a focus on highly configurable streamlined recon process via Engines, recon data correlation and organization, continuous monitoring, backed by a database, and simple yet intuitive User Interface.
GNU General Public License v3.0
52 stars 10 forks source link

ops(install): use python venv (pipx/poetry) to fix/prevent conflicting packages #84

Closed psyray closed 3 months ago

psyray commented 4 months ago

From @Talanor

Hey, here is a way of fixing the bug (and future bugs) due to conflicting packages. Every standalone python tool is installed via pipx whenever possible, or packaged using poetry and a custom pyproject.toml file. Ideally those should be reported upstream, but if not possible, such files should be maintained here.

It also does several other things:

However it kind of goes against the "update whenever you want" mentality, hence the "removal" of several volumes. So opening this in draft for discussion / testing on how it could be better handled. That being said, I'm not sure everything works as intended in main on that front either.

Talanor commented 4 months ago

Looks / works fine on my end from the testing I could do. The changes are not overly complicated but aren't benign either, needs actual review and testing on different environments.

psyray commented 4 months ago

@Talanor Could you create an issue for this PR and set the issue milestone to v2.1.0 ? Thanks

AnonymousWP commented 3 months ago

PRs aren't supposed to be added to milestones; only issues are.