search

SecurityCentral / classification-banner

Displays Classification Banner for a Graphical Session
Other
4 stars 7 forks source link

invalid monitors changed notification #12

Closed dhyams closed 10 months ago

dhyams commented 11 months ago

In banner.py, line 311, it reads

self.monitor.connet("monitors-changed", self.resize)

surely that is supposed to be "connect"?

shawndwells commented 11 months ago

Good catch. Can you submit a quick PR?

On Thu, Sep 28, 2023 at 08:48 dhyams @.***> wrote:

In banner.py, line 311, it reads

self.monitor.connet("monitors-changed", self.resize)

surely that is supposed to be "connect"?

— Reply to this email directly, view it on GitHub https://github.com/SecurityCentral/classification-banner/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLS6WSFZHJVWQZR6OLWQTDX4VW3VANCNFSM6AAAAAA5K5ENCQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

bracketttc commented 11 months ago

My PR fixes the typo, but the event doesn't appear to fire or cover the case that I thought would test it.

Testing was on Fedora 38, opened and closed the lid of my docked laptop. The laptop screen was added to the active display and desktop extended to it and then that display was removed. At no point did a debug print placed in the resize function appear in the console.

Edit: GTK's monitors-changed event only works with X11 and whatever OS X's display manager. I'm probably using Wayland on that machine.