scout2 as dependency and removal from folder

[anantshri]

Any specific reason why scout2 is added in a folder and not as a dependency in requirements. I would suggest moving them as a dependency reduces the overhead of maintaining that tool and your tool can immediately benifits from upgrades on the new version of scout2 when its released. also if you want a feature freeze give a specific version number.

[jayeshchauhan]

That was the initial plan. But if something breaks in scout2's new update.. everything breaks at our end. We saw the same in the latest update of scout2. A lot of junk data was thrown by the tool due to some subnets related checks.

On Fri, Aug 18, 2017, 17:54 Anant Shrivastava notifications@github.com wrote:

Any specific reason why scout2 is added in a folder and not as a dependency in requirements. I would suggest moving them as a dependency reduces the overhead of maintaining that tool and your tool can immediately benifits from upgrades on the new version of scout2 when its released. also if you want a feature freeze give a specific version number.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SecurityFTW/cs-suite/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ADC684-PNxFDVJFcLBgiX9yPCQi5fbJqks5sZYKKgaJpZM4O7e-n .

[anantshri]

so are we using a forked version with modifications on scout2. (might be a good idea to see if you can upstream the changes) for version related issues you can fix version via requirements file that you want specific version to be installed.

[jayeshchauhan]

Oh cool. That would be really nice. Let shivankar and I, get in touch with you and we can take it forward. Thanks !

On Fri, Aug 18, 2017, 20:10 Anant Shrivastava notifications@github.com wrote:

so are we using a forked version with modifications on scout2. (might be a good idea to see if you can upstream the changes) for version related issues you can fix version via requirements file that you want specific version to be installed.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/SecurityFTW/cs-suite/issues/1#issuecomment-323371925, or mute the thread https://github.com/notifications/unsubscribe-auth/ADC68xqkG4EuM-SuoBMkxJ_3mhD036ERks5sZaJHgaJpZM4O7e-n .

[mdeous]

Maybe you could keep it in the repo, but as a git submodule pointing to a revision known to work, this way you could easily keep it up-to-date with a recent version, and still have it "bundled" with cs-suite (I guess the same could apply to the other 3rd party tools that are being used). If you know which revisions of each tool is known to work, maybe I could submit a merge request for this.

[shivankar-madaan]

Hi @mdeous That would be really great, if you could submit a pull request for the above.Would it possible that if you can do this for lynis as well?

For Scout we are using the release https://github.com/nccgroup/Scout2/releases/tag/v3.2.1 For Lynis the latest commit or this release would also do the job https://github.com/CISOfy/lynis/releases/tag/2.6.6

Please do let us know

Thanks

[mdeous]

@shivankar-madaan I'll probably have a look at this next week-end. This could indeed work for Lynis also, as well as for prowler and Windows-Workstation-and-Server-Audit, which revision of prowler do you need? The latest? Also, I noticed there is a windows_remote.sh script in the Windows-Workstation-and-Server-Audit folder, which doesn't seem to be part of the original repo, is this something you wrote? If so, I'll move it one folder up.

[shivankar-madaan]

sure no problem, whenever you have time Yes Windows-Workstation-and-Server-Audit the latest commit will work, the windows_remote.sh is written by us, for helping cs-suite doing an local-audit on the windows server. Lynis too, the same way has a script lynis_remote.sh for the similar purpose.

For prowler I think,we might not be able to do it,since there are some custom changes which were made on the prowler code,not sure how can we go about that.Please let me know,if there is any work-around this.