search

SecurityFTW / cs-suite

Cloud Security Suite - One stop tool for auditing the security posture of AWS/GCP/Azure infrastructure.
GNU General Public License v3.0
1.14k stars 217 forks source link

No #15

Closed twneale closed 5 years ago

twneale commented 6 years ago

Why on earth would this package try to sudo via a suprocess.call shell command in setup.py? The correct way to depend on sshpass is to note it as a dependency and let users install it themselves.

shivankar-madaan commented 6 years ago

Hi @twneale

Agreed on sshpass,we can tell the users to install it themselves,but why remove rest of the installation steps?

gtback commented 6 years ago

I think it would help to remove the sudo from all of the steps in setup.py. The README already suggests running it as sudo (which can be a good or a bad thing depending on a lot of factors), so sudo in setup.py is redundant. Removing sudo would also allow people to install cs-suite into a virtualenv.

Semi-unrelated, the filename setup.py is a convention for using setuptools to distribute libraries, so it may confuse people that this setup.py does something different. It might help to rename the file to install.py or something like that.

josehelps commented 5 years ago

bump @shivankar-madaan in agreement with @twneale here. I updated https://github.com/SecurityFTW/cs-suite/pull/39 to remove setup.py and update docs to reflect how to install using virtualenv + python, once that is merge feel free to close this pull request as well.

shivankar-madaan commented 5 years ago

thanks @d1vious

Merged it!!