search

SecurityInnovation / PGPy

Pretty Good Privacy for Python
BSD 3-Clause "New" or "Revised" License
313 stars 98 forks source link

Try to avoid tox test setup failures in unit-tests and test-setup CI jobs #429

Closed dkg closed 1 year ago

dkg commented 1 year ago

I'm seeing errors like this in the test-setup and unit-tests CI jobs:

py: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'HOME ARCHFLAGS LDFLAGS CFLAGS INCLUDE LIB LD_LIBRARY_PATH PATH'

and:

py39-setup: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'HOME ARCHFLAGS LDFLAGS CFLAGS INCLUDE LIB LD_LIBRARY_PATH PATH'

Despite the fact that tox documentation says that "passenv" is "SPACE-SEPARATED-GLOBNAMES", the setup seems to think that "pass_env" (which is not "passenv", note the lack of underscore) is somehow bad. Maybe putting each value on its own line will satisfy this check?

dkg commented 1 year ago

this appears to have been a successful workaround. the remaining failures appear to be network timeouts.

I recommend merging this to get the CI back on track.

dkg commented 1 year ago

please consider merging this to get the CI back in shape. I have several patches pending that i'd love to rebase on top of this fix so i can submit them as proper merge requests.

Commod0re commented 1 year ago

https://tox.wiki/en/latest/upgrading.html#changed-ini-rules looks pretty clear