SecurityInnovation / PGPy

Pretty Good Privacy for Python
BSD 3-Clause "New" or "Revised" License
313 stars 98 forks source link

PGPKey.from_file,from_blob: Drop failed filtering of keyid mapping #454

Open dkg opened 1 year ago

dkg commented 1 year ago

This appears to have been introduced in 38a4f9f8b17fd40a2be942f58db2ecd8e67a32ee nearly 9 years ago, but it doesn't look like it ever worked.

It's not clear to me why this index of keys by key ID is returned at all in these functions, but since September 2014 (v0.3.0) the index has always returned the key ID of the primary key anyway.

There are a few things broken in this particular line:

Rather than try to salvage something that i don't understand in the first place, i figure it's better to drop it and acknowledge the status quo.