Securrency-OSS / mirai

Mirai is a Server-Driven UI (SDUI) library for Flutter. Mirai allows you to build beautiful cross-platform applications with JSON in real time.
https://pub.dev/packages/mirai
MIT License
486 stars 58 forks source link

Securrency-OSS/mirai#191 - :rocket: Added support for align widget #226

Closed loud-at-heart closed 7 months ago

loud-at-heart commented 7 months ago

Description

To add align support for Mirai

Related Issues

Closes #191

Type of Change

Added parser for Align widget

divyanshub024 commented 7 months ago

@loud-at-heart Thank you for the PR. 🚀
Can you please add the align widget example in Mirai Gallery? And please the PR checks, it's failing.

[mirai]:    info - lib/src/framework/mirai.dart:11:8 - The import of 'package:mirai/src/parsers/mirai_align/mirai_align.dart' is unnecessary because all of the used elements are also provided by the import of 'package:mirai/src/parsers/parsers.dart'. Try removing the import directive. - unnecessary_import
loud-at-heart commented 7 months ago

@loud-at-heart Thank you for the PR. 🚀 Can you please add the align widget example in Mirai Gallery? And please the PR checks, it's failing.

[mirai]:    info - lib/src/framework/mirai.dart:11:8 - The import of 'package:mirai/src/parsers/mirai_align/mirai_align.dart' is unnecessary because all of the used elements are also provided by the import of 'package:mirai/src/parsers/parsers.dart'. Try removing the import directive. - unnecessary_import

Do you need a seperate tile or adding it on container will work?

divyanshub024 commented 7 months ago

@loud-at-heart This looks good!!

loud-at-heart commented 7 months ago

@loud-at-heart This looks good!!

I added a separate tile too for align..

divyanshub024 commented 7 months ago

@loud-at-heart I think you forgot to export the MiraiAlign in parsers.dart

loud-at-heart commented 7 months ago

MiraiAlign

Sure making the change

divyanshub024 commented 7 months ago

Thank you for this PR @loud-at-heart We are grateful for your contribution 🤩