search

Securrency-OSS / mirai

Mirai is a Server-Driven UI (SDUI) library for Flutter. Mirai allows you to build beautiful cross-platform applications with JSON in real time.
https://pub.dev/packages/mirai
MIT License
478 stars 58 forks source link

feat: Replaced Image.network with CachedNetworkImage #270

Closed yousufmyk closed 2 months ago

yousufmyk commented 2 months ago

Description

Replaced Image.network with CachedNetworkImage

Related Issue

closes #255

Type of Change

divyanshub024 commented 2 months ago

@yousufmyk There are some formatting issues in mirai_image_parser can you please check?

yousufmyk commented 2 months ago

Done, You can check now

divyanshub024 commented 2 months ago

Thanks a lot, @yousufmyk, There is still some issue with the formatting. Can you please check?

Format check is failing: https://github.com/Securrency-OSS/mirai/actions/runs/8080252574/job/22077116041?pr=270

yousufmyk commented 2 months ago

I see, I've tried fixing Dart formatting Issues. Hopefully, now it should work fine.

yousufmyk commented 2 months ago

@divyanshub024 don’t know why this keeps failing I tried "dart format --set-exit-if-changed ." and it works but again getting an issue do you have any idea about this issue?

divyanshub024 commented 2 months ago

@yousufmyk Can you try running the following commands?

Make sure you have Melos installed in your system:

dart pub global activate melos

And then run

1. melos clean
2. melos bs
3. melos format
yousufmyk commented 2 months ago

@divyanshub024 Thank you for the suggestions! appreciate you taking the time to help troubleshoot.

I've now installed Melos and run the commands you provide.

yousufmyk commented 2 months ago

I can see it’s again failing but on my side it says " melos run format └> melos exec -- "dart format ." └> SUCCESS" after running melos

divyanshub024 commented 2 months ago

@yousufmyk Can you run flutter pub get in mirai_gallery? When I ran it pubspec.lock file showed some changes. Alternatively, you can also run melos bs from the root folder.

divyanshub024 commented 2 months ago

@yousufmyk Can you run flutter pub get in mirai_gallery? When I ran it pubspec.lock file showed some changes. Alternatively, you can also run melos bs from the root folder.

Hey @yousufmyk, Did it help?

divyanshub024 commented 2 months ago

Closed by #289