SedFoam / sedfoam

SedFoam solver for OpenFoam toolbox
https://sedfoam.github.io
GNU General Public License v3.0
84 stars 60 forks source link

Docker image based on Ubuntu 22.04? #172

Closed paugier closed 1 year ago

paugier commented 1 year ago

Ubuntu 22.04 comes with Python 3.10, which would be useful for testing fluidsimfoam...

paugier commented 1 year ago

https://hub.docker.com/r/opencfd/openfoam-default is based on Ubuntu 22.04, so it should be very easy...

paugier commented 1 year ago

Currently, the docker images are based on (see https://github.com/SedFoam/sedfoam/blob/master/docker/Dockerfile) opencfd/openfoam2106-default (https://hub.docker.com/r/opencfd/openfoam2106-default)

Unfortunately, there is no image opencfd/openfoam2206-default but only https://hub.docker.com/r/opencfd/openfoam-default (which is based on Ubuntu 22.04).

The dockerfiles used by opencfd are there https://develop.openfoam.com/packaging/containers

paugier commented 1 year ago

Actually, the sedfoam docker image is already based on Ubuntu 22.06. This is done here in the develop branch: https://github.com/SedFoam/sedfoam/blob/develop/docker/Dockerfile

Why do you have master and develop branches?

CyrilleBonamy commented 1 year ago

We have discussed this point at length internally. In the end, our current point of view is to release on the master branch only the big releases, which have been fully tested and validated (and which correspond to a paper), while the develop branch contains implementations of which we are not totally sure. Of course, the 1D tests (CI) always pass and give the desired results, but we sometimes have doubts about small details of the model.

Note that a new release is planned very soon (the improved kinetic theory model of the develop version has just been accepted for publication in JFM).

And yes, the sedfoam docker matches the develop branch as explained here: https://sedfoam.github.io/sedfoam/howtodocker.html Maybe this is not explicit enough.

paugier commented 1 year ago

In the doc the address is

Dockerfile : https://github.com/SedFoam/sedfoam/blob/master/docker/Dockerfile
CyrilleBonamy commented 1 year ago

oh yes... We have to change that. I'm reopening the issue to think about it

CyrilleBonamy commented 1 year ago

Done #175