Refactor ResultSetService into a new AlterationResultSetResolver

Seddryck / NBi

NBi is a testing framework (add-on to NUnit) for Business Intelligence and Data Access. The main goal of this framework is to let users create tests with a declarative approach based on an Xml syntax. By the means of NBi, you don't need to develop C# or Java code to specify your tests! Either, you don't need Visual Studio or Eclipse to compile your test suite. Just create an Xml file and let the framework interpret it and play your tests. The framework is designed as an add-on of NUnit but with the possibility to port it easily to other testing frameworks.

http://www.nbi.io

Apache License 2.0

106 stars 37 forks source link

Refactor ResultSetService into a new AlterationResultSetResolver #627

Open Seddryck opened 3 years ago

Seddryck commented 3 years ago

ResultSetService could be replaced by a IResultSetResolver that is accepting a first parameter of type IResultSetResolver and then a list of alterations. The first parameter will be executed and then the alterations applied.

That should simplify many tiny management around ResultSetService

Seddryck commented 3 years ago

Refactoring is effective but still few issues pending on a few alterations. I guess the issue is on ResultSetSystemHelper. Nevertheless, it opened a few additional debates:

Should we also refactor the alterations?
Should we also refactor the ResultSetSystemHelper? If yes, should we we move the factory to this library or not?
Should we refactor all the ResultSetResolver to not accepts the args in the constructor but all the individual parameters?

Opinions welcome.

Seddryck commented 2 years ago

Fixed issues in ResultSetSystemHelper. But questions are still pending.