Task9

[YakutovDmitriy]

• FSItem.rename. You moved file in OS, but field path of current FSItem-instance is still the same. You sohuld change it
• FSItem.create. You decide if current object is File or Directory by the last symbol of path (if self.path[-1] == '/':). But it is possible that last symbol of directory path is not /. This problem should be solved using inheritance (you should implement separate implementations of create in child classes - File.create and Directory.create)
• FSItem.getname. Now it returns full path to file (e.g. ~/a/b/f.txt) but this method should return only base name (f.txt in previous example)
• File.putcontent - good initiative :)
• Directory.items. It yield FSItem-instances. It means that I take some file from FSItem.items() and try to call getcontent here I face a problem: I can't do it. This is because I don't know if every item is file or directory. So this method should yield File and Directory instances, not just FSItem instances
• Directory.files. You use self.path + "/" + path expression here. But what if self.path = ~/a/ and path =f.txt. This expression will be incorrect. Please useos.path.join` in such context
• Directory.getsubdirectory. Two problems
  • The same as Directory.files: use os.path.join instead of expression self.path + "/" + name
  • The second check is redundant because we want to use it in the following way:

    d = Directory('.')
    d.getsubdirectory('a').create()

[YakutovDmitriy]

You do not need to open new issue when you fix mistakes I mensioned. Just write a message here that you fixed problems

[YakutovDmitriy]

• FSItem.rename. There is the following problem:

  f = File('a.txt')
  f.rename('b.exe')
  print(f.getname()) # prints still 'a.txt'

• FSItem.create - the same issue as in my previous comment
• FSItem.getname - it is almost good. But on my platfomr (I have windows) it doesn't work because there is no / symbol in windows path. You can use os.sep instead or try to find special function in module os for extracting name of file
• Directory.items. Thats ok. But this method can be implemented using files and subdirectories:

  def items(self):
      yield from self.files()
      yield from self.subdirectories()

• Directory.getsubdirectory. The second problem is still present. When we execute code below method getsubdirectory raises an error:

  d = Directory('.')
  sd = d.getsubdirectory('some_subdir') # raise Error
  sd.create()

[Sedreh]

Dear Dimitry, I did some changes and subdirectory works in my system. Maybe I can not understand your idea!

[YakutovDmitriy]

• FSItem.rename. New path can be incorrect. If old path was a/b/c and newname is asdf then new path should be /a/b/asdf
• FSItem.create
  • os.makedirs can raise an error when directory already exist. So this branch doesn't work
  • This implementation is redundant because you have separate implementations in File and Directory
  • And you still use '/'
• File.getcontent. max_lines can be greater than number of lines in file. You should bound it in such case
• Directory.items. You yield 2 object from this generator. Are you sure you want to implement it like this?