search

SeedCompany / cord-api-v3

Bible translation project management API
MIT License
18 stars 4 forks source link

Language Profile Images #1237

Open sethmcknight opened 4 years ago

sethmcknight commented 4 years ago

┆Issue is synchronized with this Monday item by Unito

glassblowerscat commented 4 years ago

@CarsonF This seems like it requires an API update, since we don't appear to have a place to store images or locations for Languages?

CarsonF commented 4 years ago

Yeah I'll move this to the API

CarsonF commented 4 years ago

The big question here is whether we create a signed url every time the picture is asked for, making it private. Or making it public, which would allow it to be cached and load faster.

glassblowerscat commented 4 years ago

The big question here is whether we create a signed url every time the picture is asked for, making it private. Or making it public, which would allow it to be cached and load faster.

How hard would it be to make the default ones public and the customized ones private? I'm guessing customization would be fairly rare, but I don't really know our user base that well

CarsonF commented 4 years ago

Yeah fallback logic is another thing to work through. Just like our other override fields, we need to know if there's actually been a picture set or not, separate from the field that encompasses the fallback.

SIgned urls are going to function very poorly in a list view.

sync-by-unito[bot] commented 1 year ago

➤ Seth McKnight commented: