SeedCompany / cord-api-v3

Bible translation project management API
MIT License
18 stars 4 forks source link

Change Requests | Approval Workflow and Notes #2084

Open sethmcknight opened 3 years ago

sethmcknight commented 3 years ago

Implement the below Steps for Change Requests.

At each Step provide a text box for the user to leave notes with their selection.

Store the notes and display the notes along with the step changes on the Change Request.

Steps for Change Requests

Step 1 | Discussing Change

Approvers

┆Issue is synchronized with this Monday item by Unito

sethmcknight commented 3 years ago

An example of how we might display the Notes and Step Changes:

Screen Shot 2021-08-12 at 1 55 13 PM
CarsonF commented 2 years ago

Ok so one step at a time. I think we need this new schema:

type Mutation {
  transitionProject(input: ProjectTransitionInput!): ProjectTransitionOutput!
}
input ProjectTransitionInput {
  id: ID!
  changeset: ID
  step: ProjectStep!
  comment: String
}
type ProjectTransitionOutput {
  project: Project!
}

type SecuredProjectStep {
  history: [ProjectStepChange!]!
}
type ProjectStepChange {
  step: ProjectStep!
  by: User!
  comment: String
}

Once this is done we can talk about integrating changeset status and project step workflows.

ParkeBrown commented 2 years ago

@sethmcknight we'll need to break this down

sethmcknight commented 2 years ago

Moved this to #2273

Ok so one step at a time. I think we need this new schema:

type Mutation {
  transitionProject(input: ProjectTransitionInput!): ProjectTransitionOutput!
}
input ProjectTransitionInput {
  id: ID!
  changeset: ID
  step: ProjectStep!
  comment: String
}
type ProjectTransitionOutput {
  project: Project!
}

type SecuredProjectStep {
  history: [ProjectStepChange!]!
}
type ProjectStepChange {
  step: ProjectStep!
  by: User!
  comment: String
}
  • Does transitionProject() or changeProjectStep() make more sense?
    • These should fully work with changesets
    • Maybe we deprecate updateProject.step for this new mutation as well?

Once this is done we can talk about integrating changeset status and project step workflows.

CarsonF commented 2 years ago