SeedCompany / cord-api-v3

Bible translation project management API
MIT License
18 stars 4 forks source link

Fix omitting `customize` `omit` acting like omitting all default methods #3144

Closed CarsonF closed 5 months ago

CarsonF commented 5 months ago

@andrewmurraydavid @bryanjnelson both of you guys hit this with project & language repos. With no omit array given, TS inferred the OmitKeys type to be all of the enum members. Giving it a default value of never suppresses that, so it will infer if the array is given or fallback to this default value which removes nothing. Honestly TS is amazing.

andrewmurraydavid commented 5 months ago

Let's go!! Thanks!