SeedCompany / cord-api-v3

Bible translation project management API
MIT License
18 stars 4 forks source link

Fix field condition not unwrapping secured values #3165

Closed CarsonF closed 4 months ago

CarsonF commented 4 months ago

Looking back, the former StatusCondition also didn't do this.

Due to calling code, this condition always worked fine when securing the object because the object wasn't secured. (Which is also what declares the canDelete boolean.) It is only when using a secured object as the context, that this bug was hit.

So this did in fact work correctly when it was written: #2863 It was only after we changed the delete check, which did use a secured object, that this bug was exposed: #2976

FYI @renatorossiter