search

SeedCompany / cord-api-v3

Bible translation project management API
MIT License
18 stars 4 forks source link

feat: project member queries #3186

Closed adam-soltech closed 2 months ago

adam-soltech commented 3 months ago

Monday task

Reason for this PR

Migrate Project Member Queries to edgedb

Description

Ready for review checklist

Use [N/A] if the item is not applicable to this PR or remove the item

  • [ ] Change the task url above to the actual Monday task
  • [ ] Add/update tests if needed
  • [ ] Add reviewers to this PR
bryanjnelson commented 2 months ago

@adam-soltech I believe you can leave the following code, this.service.privileges .for(session, ProjectMember, existing) .verifyChanges(changes); back in the service file. @bryanjnelson mentioned that the code related to privileges checking don't have to move to the repo at this time. This will allow you to also remove the service file from the constructor and import list which should then resolve the test files from breaking too. Let me know if you want to discuss.

Yes, you'll need to leave that privileges.for call in there. Also, it looks like that entire method was gutted. It should still contain one read and one update (along with the getActualChanges and verifyChanges calls - see the Wiki Page). I am unsure about the assertValidRoles call. I think that should stay, but I'll let @CarsonF weigh in on that for certainty.

CarsonF commented 2 months ago

Closing in favor of #3204