search

SeedCompany / cord-api-v3

Bible translation project management API
MIT License
18 stars 4 forks source link

Fix up Unavailability queries for EdgeDB #3188

Closed CarsonF closed 3 months ago

CarsonF commented 3 months ago

Few things missed in #3166

CarsonF commented 3 months ago

I'm not familiar with some of the things you added but it LGTM! So by adding a string literal, e.g. start and end, it acts like other properties such as, dates? I notice you could remove those props from the hydrate so curious to know when to use one way vs the other.

The backticks are just because start & end are reserved keywords in EdgeQL. Typically we favor having the computeds in the schema, because they are shared everywhere. But sometimes we just need a computed for the API that doesn't really make sense everywhere else. Having start/end shared everywhere makes sense for this type. Where as this does not.