Owner -> Audited / Actor / SystemAgent / Self

CarsonF commented 3 months ago

This kinda ballooned into several related refactors.

Our authorization system is rule based. i.e. we don't have an ACL lists in our data. We felt like owners violated this principle. It served as the object's creator, but also was mutable to allow an owner change. The waters mudded more with Users, and how they were "owned".

So owner (schema & policy conditions) is replaced by createdBy/creator. This has clearer split between raw data & authorization rules based on real data.

Related, we've also wanted to track who creates & modifies most things. So to solve this we have Audited that holds createdBy & modifiedBy. Resource was updated to extend Audited so most things can have this tracked now in a standard way.

We wanted these creators/modifiers to be required, as it's always someone that's making these changes. But there are edge cases. So now we have Actor type that's barebones and have User & SystemAgent extend from that. Hopefully a few pre-defined SystemAgents help fulfill these edge cases.

Ghost - we don't know who did it. Legacy migrated data.
Anonymous - It was actually an anonymous actor that did the action. Currently the only anonymous mutation we have is register. So this will allow us to know the user was created by someone else already logged in, or they registered themselves, or they were migrated in. Idk how helpful this will be.
External Mailing Group - For email notifications that reference mailing groups. I want to migrate to this reference instead of the Root User. It's possible that RootUser goes away soon after this change, as the ties to this user get clipped.

Finally I replaced the currentUser alias with a few globals. https://github.com/SeedCompany/cord-api-v3/blob/0c18f9b7501d34c07b95291000a449531014ffec/dbschema/common.esdl#L3-L6 Globals (single, not multi) are evaluated once per query, so this should help with performance. And be less ambiguous in use.

bryanjnelson commented 3 months ago

So you did end up combining UserStamped and TimeStamped into Audited?

CarsonF commented 3 months ago

So you did end up combining UserStamped and TimeStamped into Audited?

Yeah. I thought UserStamped made less sense with the change to Actor. Looking around Audited was suggested. And with that it made sense to include timestamps in that name. Plus it doesn't really make sense to have users/actors without timestamps.

bryanjnelson commented 3 months ago

Yeah, I like it. Seems simplified...but yet at the same time more robust.

SeedCompany / cord-api-v3

Owner -> Audited / Actor / SystemAgent / Self #3192