search

SeedCompany / cord-api-v3

Bible translation project management API
MIT License
18 stars 4 forks source link

Project Workflow: All Controllers -> FinancialApprovers #3207

Closed atGit2021 closed 5 months ago

atGit2021 commented 5 months ago

Monday Task https://seed-company-squad.monday.com/boards/5989610236/pulses/6509819818

atGit2021 commented 5 months ago

@CarsonF The only thing missing per the requirements is the desire to have the partner name added to the email notification template. I pushed up the latest commit since that will require a little bit more work as Partner is not currently passed into the template. I also assume that when Sheri says "Partner Name" added to the template, we are actually talking about the Organization name? Please verify Also, the subject line of the template is already very "full" so I added the project type to the body of the template; hope that is ok

atGit2021 commented 5 months ago

This looks good to me so far. If you want to merge and deploy this and circle back to more email info that sounds like a good idea too.

Ok, once @bryanjnelson approves, I'll squash/fixup and merge this PR and then start working a new PR for the Partner name info for the email notification

CarsonF commented 5 months ago

Ok, once @bryanjnelson approves, I'll squash/fixup and merge this PR and then start working a new PR for the Partner name info for the email notification

I got it. I'd like there to be two distinct commits here since there are two distinct changes here. I don't like "fix up previous & add new thing" in one commit.